Add a default A record for each VM #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dankenigsberg
force-pushed
the
default-a-record
branch
from
2cff250
to
b86d28a
Compare
AlonaKaplan
reviewed
Aug 8, 2023
dankenigsberg
force-pushed
the
default-a-record
branch
from
b86d28a
to
66dee13
Compare
|
This e2e can be extended - https://github.com/kubevirt/kubesecondarydns/blob/main/tests/vm_startup_test.go#L91 |
|
Thanks for the contribution:) |
dankenigsberg
force-pushed
the
default-a-record
branch
4 times, most recently
from
56ce260
to
657fc8f
Compare
make vm.namespace.<cluster> resolve to one of the VM-reported IP addresses. This may make it a bit easier to find the VM even if the user does not recall its interface names. Signed-off-by: Dan Kenigsberg <[email protected]>
dankenigsberg
force-pushed
the
default-a-record
branch
from
657fc8f
to
10a350e
Compare
|
Done in PR - #65 |
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
make vm.namespace. resolve to one of the VM-reported IP addresses. This may make it a bit easier to find the VM even if the user does not recall its interface names.
This intends to resolve https://issues.redhat.com/browse/CNV-30087
Special notes for your reviewer:
I have not tested this PR yet, it probably does not build.